-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/shmem): move shared memory logic to dedicated source file #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look's good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working. I've tested this for riscv64.
My only issue is the wording of the commit title.
I don't think "custom" is the correct term here.
Something like this is better:
feat(core/shmem): move shared memory logic to dedicated source file
Needs rebase with main @joaopeixoto13 |
@DavidMCerdeira messed up a bit, but did the rebase for @joaopeixoto13 |
This patch relocates the initialization and shared memory access steps from the hardcoded settings in the existing IPC file to a generic shared memory file. Previously, the code assumed the existence of only one object working with the shared memory (ipc). With this update, the system is now prepared for future versions where multiple objects can be added and working with the shared memory. Signed-off-by: joaopeixoto13 <joaopeixotooficial@gmail.com> Signed-off-by: Jose Martins <josemartins90@gmail.com>
This patch relocates the initialization and shared memory access steps from the hardcoded settings in the existing IPC file to a generic shared memory file. Previously, the code assumed the existence of only one object working with the shared memory (ipc). With this update, the system is now prepared for future versions where multiple objects can be added and working with the shared memory.